Fix PR review follow-ups#16
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3469b408ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!value || value.startsWith('#')) return value; | ||
|
|
||
| try { | ||
| const url = new URL(value, baseUrl); |
There was a problem hiding this comment.
When a README uses GitHub's supported repo-root-relative syntax such as [docs](/docs/guide.md) or , resolving it with new URL(value, data.html_url/download_url) treats the leading slash as the domain root, producing https://github.com/docs/guide.md or https://raw.githubusercontent.com/assets/logo.png and dropping the owner/repo/branch. This breaks those README links and images on the project detail page; root-relative paths need to be resolved against the repository root URL rather than the file URL.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
Context: PR #15 was already merged, so these are follow-up fixes for the Codex review findings.